Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set environment variable for GitHub token in default #113

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Set environment variable for GitHub token in default #113

merged 1 commit into from
Oct 9, 2019

Conversation

417-72KI
Copy link
Contributor

@417-72KI 417-72KI commented Oct 7, 2019

I want to use GitHub token as environment variable instead of --github-token command line option.

This PR makes following.

  • If --github-token is set by command line, LicensePlist uses GitHub API with it as access token.
  • Else, LicensePlist look for LICENSE_PLIST_GITHUB_TOKEN in environment.
    • If LICENSE_PLIST_GITHUB_TOKEN found, LicensePlist uses GitHub API with it as access token.
    • Else, LicensePlist uses GitHub API with no token.

@mono0926 mono0926 self-requested a review October 7, 2019 12:27
mono0926
mono0926 approved these changes Oct 9, 2019
View reviewed changes
Copy link
Owner

@mono0926 mono0926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mono0926 mono0926 merged commit 48a622c into mono0926:master Oct 9, 2019
@mono0926
Copy link
Owner

mono0926 commented Oct 9, 2019

Thanks!

@mono0926
Copy link
Owner

mono0926 commented Oct 9, 2019

Released as 2.8.1.

@417-72KI 417-72KI deleted the default-value-to-environment branch October 10, 2019 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mono0926 mono0926 mono0926 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@417-72KI @mono0926